Avoid mutating the input cubes when building the combined cube in preprocessor function multi_model_statistics
#2564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2564 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 251 251
Lines 14266 14267 +1
=======================================
+ Hits 13520 13521 +1
Misses 746 746 ☔ View full report in Codecov by Sentry. |
12 tasks
|
Just commenting to say that this fixes the issue, the new portrait plot recipe runs successfully with this Pr as tested by @lukruh and me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid mutating the input cubes when building the combined cube in preprocessor function
multi_model_statistics.Issue was introduced in #2518 and is not present in any released version of the tool.
Closes #2559
Before you get started
Checklist
It is the responsibility of the author to make sure the pull request is ready to review. The icons indicate whether the item will be subject to the 🛠 Technical or 🧪 Scientific review.
To help with the number pull requests: